vadvs (vadvs) wrote in changelog,
vadvs
vadvs
changelog

[livejournal] r17440: LJSUP-6919: Resolve 'uninitialized hash ...

Committer: vsukhanov
LJSUP-6919: Resolve 'uninitialized hash element' error in ImagePlaceholders perl module.
U   trunk/cgi-bin/LJ/Setting/ImagePlaceholders.pm
Modified: trunk/cgi-bin/LJ/Setting/ImagePlaceholders.pm
===================================================================
--- trunk/cgi-bin/LJ/Setting/ImagePlaceholders.pm	2010-09-23 10:40:57 UTC (rev 17439)
+++ trunk/cgi-bin/LJ/Setting/ImagePlaceholders.pm	2010-09-23 11:45:58 UTC (rev 17440)
@@ -2,6 +2,7 @@
 use base 'LJ::Setting';
 use strict;
 use warnings;
+no warnings 'uninitialized';
 
 sub should_render {
     my ($class, $u) = @_;
@@ -31,12 +32,9 @@
     ($maxwidth, $maxheight) = ($1, $2)
         if $imgplaceholders and $imgplaceholders =~ /^(\d+)\|(\d+)$/;
 
-    my $is_stock = {
-        "320|240" => 1,
-        "640|480" => 1,
-        "0|0" => 1,
-        "" => 1,
-    }->{$imgplaceholders};
+    my $is_stock = grep { $imgplaceholders eq $_ }
+                    (qw/320|240 640|480 0|0/, ''); # standard sizes
+
     my $extra = $class->ml('setting.imageplaceholders.option.select.custom', { width => $maxwidth, height => $maxheight })
         unless $is_stock;
 

Tags: livejournal, pm, vadvs
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 0 comments