Igor Gariev (gariev) wrote in changelog,
Igor Gariev
gariev
changelog

[livejournal] r17253: LJSUP-6694: We should change the taborde...

Committer: gariev
LJSUP-6694: We should change the taborder for comments.

U   branches/r69/cgi-bin/weblib.pl
U   branches/r69/templates/CommentForm/Author-OpenID.tmpl
U   branches/r69/templates/CommentForm/Author-User.tmpl
U   branches/r69/templates/CommentForm/Form.tmpl
Modified: branches/r69/cgi-bin/weblib.pl
===================================================================
--- branches/r69/cgi-bin/weblib.pl	2010-09-01 11:43:56 UTC (rev 17252)
+++ branches/r69/cgi-bin/weblib.pl	2010-09-01 18:13:48 UTC (rev 17253)
@@ -741,7 +741,7 @@
     $qrhtml .= "<tr><td align='right' valign='top'>";
     $qrhtml .= "<b>".BML::ml('/talkpost.bml.opt.subject')."</b></td>";
     $qrhtml .= "<td colspan='2' align='left'>";
-    $qrhtml .= "<input class='textbox' type='text' size='50' maxlength='100' name='subject' id='subject' value='' />";
+    $qrhtml .= "<input class='textbox' type='text' size='50' maxlength='100' name='subject' id='subject' value='' tabindex='10' />";
     
     $qrhtml .= "<div id=\"subjectCaptionText\">" . $text_hint . "</div>" if $text_hint;
     
@@ -751,7 +751,7 @@
     $qrhtml .= "<td align='right'><b>".BML::ml('/talkpost.bml.opt.message')."</b></td>";
     $qrhtml .= "<td colspan='3' style='width: 90%'>";
 
-    $qrhtml .= "<textarea class='textbox' rows='10' cols='50' wrap='soft' name='body' id='body' style='width: 99%'></textarea>";
+    $qrhtml .= "<textarea class='textbox' rows='10' cols='50' wrap='soft' name='body' id='body' style='width: 99%' tabindex='20'></textarea>";
     $qrhtml .= "</td></tr>";
 
     $qrhtml .= LJ::run_hook('extra_quickreply_rows', {
@@ -764,7 +764,7 @@
 
     $qrhtml .= LJ::html_submit('submitpost', BML::ml('/talkread.bml.button.post'),
                                { 'id' => 'submitpost',
-                                 'raw' => 'onclick="if (QuickReply.check()){ QuickReply.submit() }"'
+                                 'raw' => q|onclick="if (QuickReply.check()){ QuickReply.submit() }" tabindex='30' |,
                                  });
 
     $qrhtml .= "&nbsp;" . LJ::html_submit('submitmoreopts', BML::ml('/talkread.bml.button.more'),

Modified: branches/r69/templates/CommentForm/Author-OpenID.tmpl
===================================================================
--- branches/r69/templates/CommentForm/Author-OpenID.tmpl	2010-09-01 11:43:56 UTC (rev 17252)
+++ branches/r69/templates/CommentForm/Author-OpenID.tmpl	2010-09-01 18:13:48 UTC (rev 17253)
@@ -17,7 +17,7 @@
             <td class="b-postform-data">
                 <label for='talkpostfromoidlo' onclick='handleRadios(4);return false;' class="i-postform-label"><b>OpenID</b></label>
                 <TMPL_VAR ml_willscreen>
-                <span id="oid_more" class="i-bubble b-bubble-lite b-postform-openid"><i class="i-bubble-arrow-border"></i><i class="i-bubble-arrow"></i><label for="openid:url"><TMPL_VAR expr="ml('/talkpost.bml.openid.identity.url')">&nbsp;</label><input class='textbox' name='openid:url' maxlength='60' size='42' id='openid:url' value='<TMPL_VAR openid_url_default>' /> <input type='hidden' name='oiddo_login' id='oidlogincheck' <TMPL_VAR oiddo_login_checked> /> <TMPL_VAR helpicon_openid></span>
+                <span id="oid_more" class="i-bubble b-bubble-lite b-postform-openid"><i class="i-bubble-arrow-border"></i><i class="i-bubble-arrow"></i><label for="openid:url"><TMPL_VAR expr="ml('/talkpost.bml.openid.identity.url')">&nbsp;</label><input class='textbox' name='openid:url' maxlength='60' size='42' id='openid:url' value='<TMPL_VAR openid_url_default>' tabindex='1' /> <input type='hidden' name='oiddo_login' id='oidlogincheck' <TMPL_VAR oiddo_login_checked> /> <TMPL_VAR helpicon_openid></span>
             </td>
             </tr>
         </TMPL_IF>
@@ -56,7 +56,7 @@
             <td class="b-postform-data">
                 <label for='talkpostfromoidlo' onclick='handleRadios(4);return false;' class="i-postform-label"><b>OpenID</b></label>
                 <TMPL_VAR ml_willscreen>
-                <span id="oid_more" class="i-bubble b-bubble-lite b-postform-openid"><i class="i-bubble-arrow-border"></i><i class="i-bubble-arrow"></i><label for="openid:url"><TMPL_VAR expr="ml('/talkpost.bml.openid.identity.url')">&nbsp;</label><input class='textbox' name='openid:url' maxlength='60' size='42' id='openid:url' value='<TMPL_VAR openid_url_default>' /> <input type='hidden' name='oiddo_login' id='oidlogincheck' <TMPL_VAR oiddo_login_checked> /> <TMPL_VAR helpicon_openid></span>
+                <span id="oid_more" class="i-bubble b-bubble-lite b-postform-openid"><i class="i-bubble-arrow-border"></i><i class="i-bubble-arrow"></i><label for="openid:url"><TMPL_VAR expr="ml('/talkpost.bml.openid.identity.url')">&nbsp;</label><input class='textbox' name='openid:url' maxlength='60' size='42' id='openid:url' value='<TMPL_VAR openid_url_default>' tabindex='2' /> <input type='hidden' name='oiddo_login' id='oidlogincheck' <TMPL_VAR oiddo_login_checked> /> <TMPL_VAR helpicon_openid></span>
             </td>
             </tr>
         </TMPL_IF>
@@ -90,7 +90,7 @@
             <td class="b-postform-data" class="b-postform-td">
                 <label for='talkpostfromoidlo' onclick='handleRadios(4);return false;' class="i-postform-label"><b>OpenID</b></label>
                 <TMPL_VAR ml_willscreen>
-                <span id="oid_more" class="i-bubble b-bubble-lite b-postform-openid"><i class="i-bubble-arrow-border"></i><i class="i-bubble-arrow"></i><label for="openid:url"><TMPL_VAR expr="ml('/talkpost.bml.openid.identity.url')">&nbsp;</label><input class='textbox' name='openid:url' maxlength='60' size='42' id='openid:url' value='<TMPL_VAR openid_url_default>' /> <input type='hidden' name='oiddo_login' id='oidlogincheck' <TMPL_VAR oiddo_login_checked> /> <TMPL_VAR helpicon_openid></span>
+                <span id="oid_more" class="i-bubble b-bubble-lite b-postform-openid"><i class="i-bubble-arrow-border"></i><i class="i-bubble-arrow"></i><label for="openid:url"><TMPL_VAR expr="ml('/talkpost.bml.openid.identity.url')">&nbsp;</label><input class='textbox' name='openid:url' maxlength='60' size='42' id='openid:url' value='<TMPL_VAR openid_url_default>' tabindex='3' /> <input type='hidden' name='oiddo_login' id='oidlogincheck' <TMPL_VAR oiddo_login_checked> /> <TMPL_VAR helpicon_openid></span>
             </td>
             </tr>
         </TMPL_IF>

Modified: branches/r69/templates/CommentForm/Author-User.tmpl
===================================================================
--- branches/r69/templates/CommentForm/Author-User.tmpl	2010-09-01 11:43:56 UTC (rev 17252)
+++ branches/r69/templates/CommentForm/Author-User.tmpl	2010-09-01 18:13:48 UTC (rev 17253)
@@ -77,12 +77,13 @@
             <td>
                 <input class='textbox' name='userpost' size='13' maxlength='15' id='username' value='<TMPL_VAR username_default>' onclick='this.value=""'
                     style='background: url(<TMPL_VAR lj_imgprefix>/userinfo.gif) no-repeat; background-color: #fff; background-position: 0px 1px; padding-left: 18px; color: #00C; font-weight: bold;'
+                    tabindex='4'
                 />
             </td>
         </tr>
         <tr>
             <td><TMPL_VAR expr="ml('Password')">:</td>
-            <td><input class='textbox' name='password' type='password' maxlength='30' size='18' id='password' /></td>
+            <td><input class='textbox' name='password' type='password' maxlength='30' size='18' id='password' tabindex='5' /></td>
         </tr>
         <tr>
             <td colspan='2'>

Modified: branches/r69/templates/CommentForm/Form.tmpl
===================================================================
--- branches/r69/templates/CommentForm/Form.tmpl	2010-09-01 11:43:56 UTC (rev 17252)
+++ branches/r69/templates/CommentForm/Form.tmpl	2010-09-01 18:13:48 UTC (rev 17253)
@@ -49,7 +49,7 @@
 <tr valign='top'>
     <td align='right'><TMPL_VAR expr="ml('/talkpost.bml.opt.subject')"></td>
     <td>
-        <input class='textbox' type='text' size='50' maxlength='100' name='subject' id='subject' value="<TMPL_VAR basesubject>" onKeyPress='subjectNoHTML(event);'/>
+        <input class='textbox' type='text' size='50' maxlength='100' name='subject' id='subject' value="<TMPL_VAR basesubject>" onKeyPress='subjectNoHTML(event);' tabindex='10' />
 
         <TMPL_IF 0> subject icon </TMPL_IF>
             <input type='hidden' id='subjectIconField' name='subjecticon' value='$subjicon'>
@@ -162,7 +162,7 @@
 <tr valign='top'>
     <td align='right'><TMPL_VAR expr="ml('/talkpost.bml.opt.message')"></td>
     <td style='width: 90%'>
-        <textarea class='textbox' rows='10' cols='75' wrap='soft' name='body' id='commenttext'><TMPL_VAR comment_body></textarea>
+        <textarea class='textbox' rows='10' cols='75' wrap='soft' name='body' id='commenttext' tabindex='20'><TMPL_VAR comment_body></textarea>
     </td>
 </tr>
 
@@ -192,7 +192,7 @@
             // -->
         </script>
 
-        <input type='submit' name='submitpost' onclick='return checkLength() && sendForm("postform", "username")'
+        <input type='submit' name='submitpost' onclick='return checkLength() && sendForm("postform", "username")' tabindex='30'
             <TMPL_IF editid>
                 value="<TMPL_VAR expr="ml('/talkpost.bml.opt.edit')">"
             <TMPL_ELSE>

Tags: gariev, livejournal, pl, tmpl
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 0 comments