´ (revmischa) wrote in changelog,
´
revmischa
changelog

livejournal

Module Name: livejournal
Committed By: mischa
Date: Fri Oct 21 07:59:06 UTC 2005

Modified Files:
---------------
livejournal/htdocs/js: commentmanage.js

Log Message:
------------
Brad -= 4 (one point per hour I spent tracking down this bug)
Mischa++
So I was wondering, "gosh, why could it be that internet explorer is acting
as if my onclick handlers are returning true no matter what they actually return?
why could it be that all links are being followed, in addition to my javascript?"
It turns out commentmanage.js registers an onclick handler for document which
always returns true. This is not only unnecessary, but very detrimental to
any sort of sane event handling on a page. Simply removing "return true" from
the handler seems to fix everything, and as far as I can tell everything behaves
as it should still in IE, Firefox and Safari. If anyone is a JS event genius
please inform me if there is a better solution to hiding popups, or if not
returning anything could have undesired behavior.


To generate a diff of this commit:
cvs rdiff -r1.8 -r1.9 livejournal/htdocs/js/commentmanage.js
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/js/commentmanage.js.diff?r1=1.8&r2=1.9
Subscribe

  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 3 comments