October 21st, 2005

livejournal

Module Name: livejournal
Committed By: mischa
Date: Fri Oct 21 07:59:06 UTC 2005

Modified Files:
---------------
livejournal/htdocs/js: commentmanage.js

Log Message:
------------
Brad -= 4 (one point per hour I spent tracking down this bug)
Mischa++
So I was wondering, "gosh, why could it be that internet explorer is acting
as if my onclick handlers are returning true no matter what they actually return?
why could it be that all links are being followed, in addition to my javascript?"
It turns out commentmanage.js registers an onclick handler for document which
always returns true. This is not only unnecessary, but very detrimental to
any sort of sane event handling on a page. Simply removing "return true" from
the handler seems to fix everything, and as far as I can tell everything behaves
as it should still in IE, Firefox and Safari. If anyone is a JS event genius
please inform me if there is a better solution to hiding popups, or if not
returning anything could have undesired behavior.


To generate a diff of this commit:
cvs rdiff -r1.8 -r1.9 livejournal/htdocs/js/commentmanage.js
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/js/commentmanage.js.diff?r1=1.8&r2=1.9

livejournal

Module Name: livejournal
Committed By: mischa
Date: Fri Oct 21 08:32:05 UTC 2005

Modified Files:
---------------
livejournal/htdocs/js: portal.js
livejournal/htdocs/portal: index.bml

Log Message:
------------
Serious JS cleanup, close menu on click outside


To generate a diff of this commit:
cvs rdiff -r1.13 -r1.14 livejournal/htdocs/js/portal.js
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/js/portal.js.diff?r1=1.13&r2=1.14
cvs rdiff -r1.24 -r1.25 livejournal/htdocs/portal/index.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/portal/index.bml.diff?r1=1.24&r2=1.25

livejournal

Module Name: livejournal
Committed By: mischa
Date: Fri Oct 21 08:43:54 UTC 2005

Modified Files:
---------------
livejournal/cgi-bin/LJ/Portal/Box: FriendsPage.pm

Log Message:
------------
Add use image placeholders option to friendspage


To generate a diff of this commit:
cvs rdiff -r1.12 -r1.13 livejournal/cgi-bin/LJ/Portal/Box/FriendsPage.pm
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/LJ/Portal/Box/FriendsPage.pm.diff?r1=1.12&r2=1.13

livejournal

Module Name: livejournal
Committed By: davidr
Date: Fri Oct 21 18:43:13 UTC 2005

Modified Files:
---------------
livejournal/htdocs: imgupload.bml
livejournal/htdocs/js: entry.js

Log Message:
------------
- Add ability to set window title
- Resize to small after a timeout to avoid a scrollbar


To generate a diff of this commit:
cvs rdiff -r1.14 -r1.15 livejournal/htdocs/imgupload.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/imgupload.bml.diff?r1=1.14&r2=1.15
cvs rdiff -r1.23 -r1.24 livejournal/htdocs/js/entry.js
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/js/entry.js.diff?r1=1.23&r2=1.24

livejournal

Module Name: livejournal
Committed By: davidr
Date: Fri Oct 21 23:50:07 UTC 2005

Modified Files:
---------------
livejournal/htdocs: imgupload.bml
livejournal/htdocs/js: entry.js

Log Message:
------------
- No margin around div
- Hide iframe border
- Make window resize when browser size changes


To generate a diff of this commit:
cvs rdiff -r1.15 -r1.16 livejournal/htdocs/imgupload.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/imgupload.bml.diff?r1=1.15&r2=1.16
cvs rdiff -r1.24 -r1.25 livejournal/htdocs/js/entry.js
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/js/entry.js.diff?r1=1.24&r2=1.25

livejournal

Module Name: livejournal
Committed By: mischa
Date: Sat Oct 22 01:27:05 UTC 2005

Modified Files:
---------------
livejournal/cgi-bin/LJ: Portal.pm
livejournal/cgi-bin/LJ/Portal: Config.pm
livejournal/htdocs/portal: index.bml

Log Message:
------------
Debug module
Profiling option (needs Time::HiRes and Benchmark modules)
Ability to have hidden modules (both defined in the module and in ljconfig)
Ability to add hidden modules with URL argument


To generate a diff of this commit:
cvs rdiff -r1.25 -r1.26 livejournal/cgi-bin/LJ/Portal.pm
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/LJ/Portal.pm.diff?r1=1.25&r2=1.26
cvs rdiff -r1.21 -r1.22 livejournal/cgi-bin/LJ/Portal/Config.pm
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/LJ/Portal/Config.pm.diff?r1=1.21&r2=1.22
cvs rdiff -r1.25 -r1.26 livejournal/htdocs/portal/index.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/portal/index.bml.diff?r1=1.25&r2=1.26

livejournal

Module Name: livejournal
Committed By: mischa
Date: Sat Oct 22 02:48:58 UTC 2005

Modified Files:
---------------
livejournal/htdocs/portal: index.bml

Log Message:
------------
Comment was right, code was wrong
Also, remove close button image, not used anymore


To generate a diff of this commit:
cvs rdiff -r1.26 -r1.27 livejournal/htdocs/portal/index.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/portal/index.bml.diff?r1=1.26&r2=1.27

livejournal

Module Name: livejournal
Committed By: mischa
Date: Sat Oct 22 02:50:20 UTC 2005

Modified Files:
---------------
livejournal/htdocs/js: portal.js

Log Message:
------------
Make portal fading stuff work better/be more compatible.
Tip: You can turn on $LJ::PORTAL_DOFADE in ljconfig for cool fading action


To generate a diff of this commit:
cvs rdiff -r1.15 -r1.16 livejournal/htdocs/js/portal.js
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/js/portal.js.diff?r1=1.15&r2=1.16

livejournal

Module Name: livejournal
Committed By: mischa
Date: Sat Oct 22 03:17:06 UTC 2005

Modified Files:
---------------
livejournal/cgi-bin: cleanhtml.pl
livejournal/cgi-bin/LJ/Portal/Box: FriendsPage.pm

Log Message:
------------
Don't double-clean entries
clean_event understands image placeholder opt


To generate a diff of this commit:
cvs rdiff -r1.128 -r1.129 livejournal/cgi-bin/cleanhtml.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/cleanhtml.pl.diff?r1=1.128&r2=1.129
cvs rdiff -r1.13 -r1.14 livejournal/cgi-bin/LJ/Portal/Box/FriendsPage.pm
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/LJ/Portal/Box/FriendsPage.pm.diff?r1=1.13&r2=1.14