September 28th, 2005

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Wed Sep 28 07:23:20 UTC 2005

Modified Files:
---------------
livejournal/cgi-bin/LJ: Entry.pm

Log Message:
------------
don't show mass-action bar on S2 EntryPages for any logged in
user... just the right one. bug was introduced here:

http://changelog.livejournal.com/2311944.html?mode=reply

when porting these pages to use LJ::Entry. whoops. negative points
to brad.

thanks to "isabeau", who pointed out the problem here:

http://www.livejournal.com/community/lj_support/586047.html?thread=5135679#t5135679


To generate a diff of this commit:
cvs rdiff -r1.8 -r1.9 livejournal/cgi-bin/LJ/Entry.pm
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/LJ/Entry.pm.diff?r1=1.8&r2=1.9

ljcom

Module Name: ljcom
Committed By: davidr
Date: Wed Sep 28 17:48:56 UTC 2005

Modified Files:
---------------
ljcom/bin/upgrading: en_LJ.dat
ljcom/cgi-bin/bml/scheme: dystopia.look
ljcom/htdocs/site: search.bml

Log Message:
------------
Add schools directory to site nav


To generate a diff of this commit:
cvs rdiff -r1.126 -r1.127 ljcom/bin/upgrading/en_LJ.dat
http://cvs.livejournal.org/browse.cgi/ljcom/bin/upgrading/en_LJ.dat.diff?r1=1.126&r2=1.127
cvs rdiff -r1.28 -r1.29 ljcom/cgi-bin/bml/scheme/dystopia.look
http://cvs.livejournal.org/browse.cgi/ljcom/cgi-bin/bml/scheme/dystopia.look.diff?r1=1.28&r2=1.29
cvs rdiff -r1.3 -r1.4 ljcom/htdocs/site/search.bml
http://cvs.livejournal.org/browse.cgi/ljcom/htdocs/site/search.bml.diff?r1=1.3&r2=1.4

livejournal

Module Name: livejournal
Committed By: davidr
Date: Wed Sep 28 18:13:50 UTC 2005

Modified Files:
---------------
livejournal/htdocs/schools: index.bml

Log Message:
------------
- Messaging change "undefined" vs "no defined"
- Sort country list with US and CA on top


To generate a diff of this commit:
cvs rdiff -r1.22 -r1.23 livejournal/htdocs/schools/index.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/schools/index.bml.diff?r1=1.22&r2=1.23

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Wed Sep 28 18:48:55 UTC 2005

Modified Files:
---------------
livejournal/cgi-bin/LJ: User.pm

Log Message:
------------
when people are in S2 but either they don't have access to entry/reply
views, or the S2 view disables it, let it fall back to s1shortcomings
if the fallback=s2 option is on. previously it only fell back if the
global flag was on.


To generate a diff of this commit:
cvs rdiff -r1.49 -r1.50 livejournal/cgi-bin/LJ/User.pm
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/LJ/User.pm.diff?r1=1.49&r2=1.50

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Wed Sep 28 18:51:57 UTC 2005

Modified Files:
---------------
livejournal/cgi-bin: talklib.pl
livejournal/cgi-bin/LJ/S2: EntryPage.pm

Log Message:
------------
fix for "S2 double-converts comment times to GMT"
http://zilla.livejournal.org/show_bug.cgi?id=2461


To generate a diff of this commit:
cvs rdiff -r1.186 -r1.187 livejournal/cgi-bin/talklib.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/talklib.pl.diff?r1=1.186&r2=1.187
cvs rdiff -r1.61 -r1.62 livejournal/cgi-bin/LJ/S2/EntryPage.pm
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/LJ/S2/EntryPage.pm.diff?r1=1.61&r2=1.62

livejournal

Module Name: livejournal
Committed By: davidr
Date: Wed Sep 28 18:55:30 UTC 2005

Modified Files:
---------------
livejournal/htdocs/schools: index.bml

Log Message:
------------
- Always pass in as state instead of statecode, library takes care of this
- Uppercase US state abbreviations


To generate a diff of this commit:
cvs rdiff -r1.24 -r1.25 livejournal/htdocs/schools/index.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/schools/index.bml.diff?r1=1.24&r2=1.25

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Wed Sep 28 21:13:53 UTC 2005

Modified Files:
---------------
livejournal/cgi-bin: ljlib.pl

Log Message:
------------
easier code-go-livin':

if a prop doesn't exist and you've already loaded all props for that
table, just try again. somebody probably just ran the prop upgrader
from base-data.sql


To generate a diff of this commit:
cvs rdiff -r1.905 -r1.906 livejournal/cgi-bin/ljlib.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/ljlib.pl.diff?r1=1.905&r2=1.906

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Wed Sep 28 22:17:08 UTC 2005

Modified Files:
---------------
livejournal/bin/upgrading: base-data.sql

Log Message:
------------
XATTENTION: stop manually editting this file!

See the comment at top of it? You're never supposed to manually
hand-edit it... just modify your database, run dumpsql.pl, and make a
diff from that. If the diff isn't short and sweet and to the point,
then you did something wrong: forget to populate your database with
old basedata.sql first? forget to clean out development props? etc,
etc.

Mischa the other day wasted a whole bunch of time trying to figure out
why his dumpsql.pl wasn't make clean diffs, and today I wasted a bunch
of time too.....

I was pulling my hair out until Junior told me, "oh, everybody just
modifies that file by hand". And then I wanted to pull all your hair
out.

So this is a clean-up patch. My upcoming base-data.sql patch will be
clean and to-the-point, once this is patch is in.


To generate a diff of this commit:
cvs rdiff -r1.113 -r1.114 livejournal/bin/upgrading/base-data.sql
http://cvs.livejournal.org/browse.cgi/livejournal/bin/upgrading/base-data.sql.diff?r1=1.113&r2=1.114

ljcom

Module Name: ljcom
Committed By: bradfitz
Date: Wed Sep 28 22:18:04 UTC 2005

Modified Files:
---------------
ljcom/bin/upgrading: base-data-local.sql

Log Message:
------------
running dumpsql.pl on this too, rather than the hand-editing crap
that's plagued it.


To generate a diff of this commit:
cvs rdiff -r1.26 -r1.27 ljcom/bin/upgrading/base-data-local.sql
http://cvs.livejournal.org/browse.cgi/ljcom/bin/upgrading/base-data-local.sql.diff?r1=1.26&r2=1.27

livejournal

Module Name: livejournal
Committed By: davidr
Date: Wed Sep 28 23:30:26 UTC 2005

Modified Files:
---------------
livejournal/cgi-bin: schoollib.pl
livejournal/htdocs/admin/schools: edit.bml

Log Message:
------------
Add the ability for admins to delete existing schools


To generate a diff of this commit:
cvs rdiff -r1.9 -r1.10 livejournal/cgi-bin/schoollib.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/schoollib.pl.diff?r1=1.9&r2=1.10
cvs rdiff -r1.1 -r1.2 livejournal/htdocs/admin/schools/edit.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/admin/schools/edit.bml.diff?r1=1.1&r2=1.2

livejournal

Module Name: livejournal
Committed By: davidr
Date: Wed Sep 28 23:43:34 UTC 2005

Modified Files:
---------------
livejournal/cgi-bin: schoollib.pl
livejournal/htdocs/schools: index.bml

Log Message:
------------
- Add and use a city name canonicalizer, stripped down version of school name one
- Don't strip city off the end of a school's name, decision was it is actually causing
more trouble than it is solving


To generate a diff of this commit:
cvs rdiff -r1.10 -r1.11 livejournal/cgi-bin/schoollib.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/schoollib.pl.diff?r1=1.10&r2=1.11
cvs rdiff -r1.26 -r1.27 livejournal/htdocs/schools/index.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/schools/index.bml.diff?r1=1.26&r2=1.27
woo!
  • mahlon

ljcom

Module Name: ljcom
Committed By: mahlon
Date: Thu Sep 29 00:05:51 UTC 2005

Modified Files:
---------------
ljcom/bin/upgrading: en_LJ.dat
ljcom/htdocs/manage: voicepost.bml
ljcom/htdocs/voicepost: index.bml

Log Message:
------------
I certainly make a lot of typos.

Bunch 'o text fixes, as pointed out by ljkrissy.


To generate a diff of this commit:
cvs rdiff -r1.127 -r1.128 ljcom/bin/upgrading/en_LJ.dat
http://cvs.livejournal.org/browse.cgi/ljcom/bin/upgrading/en_LJ.dat.diff?r1=1.127&r2=1.128
cvs rdiff -r1.1 -r1.2 ljcom/htdocs/manage/voicepost.bml
http://cvs.livejournal.org/browse.cgi/ljcom/htdocs/manage/voicepost.bml.diff?r1=1.1&r2=1.2
cvs rdiff -r1.2 -r1.3 ljcom/htdocs/voicepost/index.bml
http://cvs.livejournal.org/browse.cgi/ljcom/htdocs/voicepost/index.bml.diff?r1=1.2&r2=1.3

livejournal

Module Name: livejournal
Committed By: mischa
Date: Thu Sep 29 00:17:16 UTC 2005

Modified Files:
---------------
livejournal/cgi-bin/LJ/Portal: Config.pm
livejournal/cgi-bin/LJ/Portal/Box: Friends.pm

Log Message:
------------
Disable FriendsPage until less ugly
Make friends box have more accurate text for what it does (lameness)
Friends will be cooler in future, but for now reflect lameness


To generate a diff of this commit:
cvs rdiff -r1.7 -r1.8 livejournal/cgi-bin/LJ/Portal/Config.pm
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/LJ/Portal/Config.pm.diff?r1=1.7&r2=1.8
cvs rdiff -r1.2 -r1.3 livejournal/cgi-bin/LJ/Portal/Box/Friends.pm
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/LJ/Portal/Box/Friends.pm.diff?r1=1.2&r2=1.3
potato

livejournal

Module Name: livejournal
Committed By: marksmith
Date: Thu Sep 29 00:59:58 UTC 2005

Modified Files:
---------------
livejournal/bin/upgrading: update-db-general.pl

Log Message:
------------
* use mediumtext for bigger includes (support-guide breaks 65kb)


To generate a diff of this commit:
cvs rdiff -r1.200 -r1.201 livejournal/bin/upgrading/update-db-general.pl
http://cvs.livejournal.org/browse.cgi/livejournal/bin/upgrading/update-db-general.pl.diff?r1=1.200&r2=1.201

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Thu Sep 29 01:01:46 UTC 2005

Modified Files:
---------------
livejournal/bin/upgrading: base-data.sql
livejournal/bin/upgrading/s2layers: core1.s2
livejournal/bin/upgrading/s2layers/generator: layout.s2
livejournal/cgi-bin: modperl_subs.pl
livejournal/cgi-bin/LJ: S2.pm
livejournal/cgi-bin/LJ/S2: EntryPage.pm
livejournal/htdocs: editinfo.bml

Log Message:
------------
Timezone support:

-- users can set their default timezone on editinfo.bml, with
old-school but easier-to-find US/* aliases at top, for our
US homies. (eg, US/Pacific just maps to America/Los_Angeles)

-- provide more time information to S2's comment class: the
seconds elapsed from the time of the journal entry being
posted to the time of the comment, the comment's localtime
in remote user's timezone, the comment's localtime in
the commenter's timezone

-- make new method in the core (overridable) on the Comment
object to return text like "+8 hours" in an [abbr] tag
so Firefox/Safari users can hover over it and see:

"8 hours after journal entry, 4/16/08 5:32 pm (your time), 8:32 pm (bob's time)"

this doesn't work in IE, but the times before were useless anyway.
we'll figure something out for IE.... or not. we'll see.
we'll let you guys be creative in using all this new data
and APIs. whatever is found to be best visually (remember
that the date/time information is generally useless), we'll
use as the default

-- update generator to use core's APIs, as a demo.

1 day project. Whowoulddathunkit.

Now that we'll be getting timezone information from users, we'll do
more with the timezone data in the future. Babysteps.


To generate a diff of this commit:
cvs rdiff -r1.114 -r1.115 livejournal/bin/upgrading/base-data.sql
http://cvs.livejournal.org/browse.cgi/livejournal/bin/upgrading/base-data.sql.diff?r1=1.114&r2=1.115
cvs rdiff -r1.115 -r1.116 livejournal/bin/upgrading/s2layers/core1.s2
http://cvs.livejournal.org/browse.cgi/livejournal/bin/upgrading/s2layers/core1.s2.diff?r1=1.115&r2=1.116
cvs rdiff -r1.60 -r1.61 \
livejournal/bin/upgrading/s2layers/generator/layout.s2
http://cvs.livejournal.org/browse.cgi/livejournal/bin/upgrading/s2layers/generator/layout.s2.diff?r1=1.60&r2=1.61
cvs rdiff -r1.33 -r1.34 livejournal/cgi-bin/modperl_subs.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/modperl_subs.pl.diff?r1=1.33&r2=1.34
cvs rdiff -r1.183 -r1.184 livejournal/cgi-bin/LJ/S2.pm
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/LJ/S2.pm.diff?r1=1.183&r2=1.184
cvs rdiff -r1.62 -r1.63 livejournal/cgi-bin/LJ/S2/EntryPage.pm
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/LJ/S2/EntryPage.pm.diff?r1=1.62&r2=1.63
cvs rdiff -r1.75 -r1.76 livejournal/htdocs/editinfo.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/editinfo.bml.diff?r1=1.75&r2=1.76