September 8th, 2005

computer crap

ljcom

Module Name: ljcom
Committed By: whitaker
Date: Thu Sep 8 18:15:35 UTC 2005

Modified Files:
---------------
ljcom/htdocs/pay: modify.bml

Log Message:
------------
-- add comments at the end of some enormous blocks

-- add some comments about auto-vivification checking

-- make $ensurecart->() return 0/1, indicating success/error. that way we
can check it later before assuming it created a valid cart object that
we can start calling methods on. think this might be the cause of some
"can't call method *** on unblessed reference" problems.


To generate a diff of this commit:
cvs rdiff -r1.45 -r1.46 ljcom/htdocs/pay/modify.bml
http://cvs.livejournal.org/browse.cgi/ljcom/htdocs/pay/modify.bml.diff?r1=1.45&r2=1.46
amused, happy
  • mart

wcmtools

Module Name: wcmtools
Committed By: mart

Modified Files:
---------------
wcmtools/s2: S2.pm
wcmtools/s2/tests: super.s2.out

Log Message:
------------
In retrospect, this change to $super's behaviour was misguided. The old behavior
was actually the correct one. (Resolve the superclass in the context of the call,
not in the context of the object's class.)

Also update the super test to have the correct sample output.


To generate a diff of this commit:
cvs rdiff -r1.46 -r1.47 wcmtools/s2/S2.pm
http://cvs.danga.com/browse.cgi/wcmtools/s2/S2.pm.diff?r1=1.46&r2=1.47
cvs rdiff -r1.1 -r1.2 wcmtools/s2/tests/super.s2.out
http://cvs.danga.com/browse.cgi/wcmtools/s2/tests/super.s2.out.diff?r1=1.1&r2=1.2
computer crap

ljcom

Module Name: ljcom
Committed By: whitaker
Date: Thu Sep 8 18:51:56 UTC 2005

Modified Files:
---------------
ljcom/bin/maint: pay.pl

Log Message:
------------
Since we're currently sending the Frank mosaic poster ourselves and not
through the normal distributor, and have already hacked the shipping_labels
tool to not confuse them, need to do the same in the shipping notify email.

This requires loading payment objects instead of just doing a quick count
from the shipping table, but nothing complicated. Also cleaned up english
a bit in the case that there are no orders in need of shipping.


To generate a diff of this commit:
cvs rdiff -r1.63 -r1.64 ljcom/bin/maint/pay.pl
http://cvs.livejournal.org/browse.cgi/ljcom/bin/maint/pay.pl.diff?r1=1.63&r2=1.64
computer crap

ljcom

Module Name: ljcom
Committed By: whitaker
Date: Thu Sep 8 19:18:27 UTC 2005

Modified Files:
---------------
ljcom/bin/maint: pay.pl

Log Message:
------------
-- Pass $ru instead of $ru->{userid} into LJ::Pay::add_paid_months()
so it can update the caps on the $ru object for us. This was causing
invalid text being displayed in the following email.


To generate a diff of this commit:
cvs rdiff -r1.65 -r1.66 ljcom/bin/maint/pay.pl
http://cvs.livejournal.org/browse.cgi/ljcom/bin/maint/pay.pl.diff?r1=1.65&r2=1.66

livejournal

Module Name: livejournal
Committed By: davidr
Date: Thu Sep 8 20:29:53 UTC 2005

Modified Files:
---------------
livejournal/htdocs/support: see_request.bml

Log Message:
------------
Simplify logic in terms of when we display user and email history links. Also
make the rules more usable in terms of not making people jump through hoops to get
information they already have access to.


To generate a diff of this commit:
cvs rdiff -r1.104 -r1.105 livejournal/htdocs/support/see_request.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/support/see_request.bml.diff?r1=1.104&r2=1.105
woo!
  • mahlon

livejournal

Module Name: livejournal
Committed By: mahlon
Date: Thu Sep 8 22:50:11 UTC 2005

Modified Files:
---------------
livejournal/cgi-bin: ljfeed.pl parsefeed.pl
livejournal/cgi-bin/Apache/LiveJournal/Interface: AtomAPI.pm

Log Message:
------------
Update our Atom outgoing feed to 1.1-draft specifications.

Pre 0.6 tags have been left in place where possible for the time being,
to help ease transitioning.

- use XML::Atom everywhere we can instead of manually generating tags.
- 'created' tag is no more
- renamed tags:
issued -> published
modified -> updated
tagline -> subtitle
- added rel='self' link
- feed now requires unique id
- feed version attribute removed
- 'mode' data attribute removed, replaced with 'type'
- author information only sometimes required

Still todo:
- Eventually phase out pre 0.6 tags.
- Update atom protocol parser (maintain protocol compatibility with
pre 0.6 for nokia support)
- Change namespace to reflect Atom 1.0 release... when it is finalized.


To generate a diff of this commit:
cvs rdiff -r1.34 -r1.35 livejournal/cgi-bin/ljfeed.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/ljfeed.pl.diff?r1=1.34&r2=1.35
cvs rdiff -r1.10 -r1.11 livejournal/cgi-bin/parsefeed.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/parsefeed.pl.diff?r1=1.10&r2=1.11
cvs rdiff -r1.17 -r1.18 \
livejournal/cgi-bin/Apache/LiveJournal/Interface/AtomAPI.pm
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/Apache/LiveJournal/Interface/AtomAPI.pm.diff?r1=1.17&r2=1.18