Module Name: ljcom
Committed By: bradfitz
Date: Sun Jun 30 19:25:00 UTC 2002
This patch fixes a problem with the width of LJ tables in the
template. The problem doesn't manifest itself in English, but only
when other languages are used.
Quick description. Search bar and logged-in bar are currently
implemented with two rows. Search bar has one empty column of 19%
and the rest, the actual search fields, are in a [td colspan=2
align=right]tag. The logged-in bar has three columns: 19% for the
hello message, 34% empty and remaining 47% for useful links.
For some languages, the "Welcome to LiveJournal!" text in the
logged-in bar is too long to coexist with the search fields in the
[td colspan=2 align=right] tag in the search bar. As a result the
browser (IE in particular) expands the whole table in width and
enforces horizontal scrolling for the whole page. This is very
inconvenient for the user.
The long "Welcome to LiveJournal!" message is actually short enough to
coexist peacefully with the other text in its own row; it
conflicts with the search row above it because it lives in the first
column of the logged-in bar which is identified with the first column
of the search bar. So, uniting this message with the next "empty" column
after it in the logged-in bar into a colspan=2 tag solves the problem.
The patch has been tested on IE and Opera, and should work fine on
other browsers. We already use colspan elsewhere in the same template,
so there's no new HTML functionality.bradfitz
: works great in IE, but not perfectly in Mozilla.
thinking there's still a problem somewhere. some numbers off?
To generate a diff of this commit:
cvs rdiff -r1.30 -r1.31 ljcom/cgi-bin/bml/scheme/dystopia/generic.lookhttp://cvs.livejournal.org/browse.cgi/ljcom/cgi-bin/bml/scheme/dystopia/generic.look.diff?r1=1.30&r2=1.31