May 5th, 2002

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Sun May 5 07:32:57 UTC 2002

Modified Files:
---------------
livejournal/htdocs/translate: editpage.bml

Log Message:
------------
forgot to pass to ljlang who was saving the text, so we were logging
zeros in the db. boring data.


To generate a diff of this commit:
cvs rdiff -r1.11 -r1.12 livejournal/htdocs/translate/editpage.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/translate/editpage.bml.diff?r1=1.11&r2=1.12

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Sun May 5 18:40:15 UTC 2002

Modified Files:
---------------
livejournal/htdocs/tools: memadd.bml

Log Message:
------------
avva: Two fixes:
1. Trying to edit pre-clustering memories deleted them (bad conditions
for testing deleted entries in the code).
2. Let description and keyword input fields have their real maxlength
determined by LJ:: constants, rather than hardcoded values.
Tested.


To generate a diff of this commit:
cvs rdiff -r1.15 -r1.16 livejournal/htdocs/tools/memadd.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/tools/memadd.bml.diff?r1=1.15&r2=1.16

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Sun May 5 19:01:46 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin: ljprotocol.pl

Log Message:
------------
avva: Hey,

This patch fixes a security bug when deleting friend groups. You never
clustered the code that resets the deleted bit on old entries. I
suspect this is what's been causing rare mysterious friend group
screwups support people've been struggling with.

I tested it, but I never clustered old code before so please review.

bradfitz: looks good. can't believe i forgot that.


To generate a diff of this commit:
cvs rdiff -r1.93 -r1.94 livejournal/cgi-bin/ljprotocol.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/ljprotocol.pl.diff?r1=1.93&r2=1.94

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Sun May 5 19:13:37 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin: ljlib.pl

Log Message:
------------
avva: The existing check on interest length, <=35 bytes, is too short for
non-ASCII interests in UTF-8. This patch adds BMAX_ and CMAX_
constants for interest length and changes the check; the restrictions
are set to 50 chars and 100 bytes. Tested.


To generate a diff of this commit:
cvs rdiff -r1.186 -r1.187 livejournal/cgi-bin/ljlib.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/ljlib.pl.diff?r1=1.186&r2=1.187

ljcom

Module Name: ljcom
Committed By: bradfitz
Date: Sun May 5 19:34:55 UTC 2002

Modified Files:
---------------
ljcom/htdocs/developer: modeinfo.bml
Added Files:
------------
ljcom/htdocs/developer: versions.bml

Log Message:
------------
avva: Here's the protocol docs patch by evan, reviewed by me. Here's what
Evan did:

- added an .optional attribute in protocol.dat and used it everywhere
instead of various ad-hoc "Optional" messages.
- XHTMLified modeinfo.bml
- added information about the "ver" attribute to every mode and a
versions.bml file to explain versions.

What I did:

- reviewed and tested;
- fixed an error in protocol.dat where Evan erroneously claimed the
events_count attribute in getevents response to be optional;
- changed the .optional text from (Optional.) to
(Optional) because I think it looks much better this way, feel
free to disagree.
- expanded and rewrote versions.bml, and also removed a link to the news entry about Unicode from it (too livejournal.com - specific
even for a ljcom distribution, I think - and not really necessary to a
developer).


To generate a diff of this commit:
cvs rdiff -r1.4 -r1.5 ljcom/htdocs/developer/modeinfo.bml
http://cvs.livejournal.org/browse.cgi/ljcom/htdocs/developer/modeinfo.bml.diff?r1=1.4&r2=1.5
cvs rdiff -r0 -r1.1 ljcom/htdocs/developer/versions.bml
http://cvs.livejournal.org/browse.cgi/ljcom/htdocs/developer/versions.bml.diff?r1=0&r2=1.1

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Sun May 5 19:36:15 UTC 2002

Modified Files:
---------------
livejournal/htdocs: protocol.dat

Log Message:
------------
general part of last patch:
http://www.livejournal.com/talkpost.bml?journal=changelog&itemid=215379


To generate a diff of this commit:
cvs rdiff -r1.5 -r1.6 livejournal/htdocs/protocol.dat
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/protocol.dat.diff?r1=1.5&r2=1.6

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Sun May 5 19:54:53 UTC 2002

Modified Files:
---------------
livejournal/htdocs: update.bml

Log Message:
------------
avva: Fixes one of the popular support bugs: update.bml doesn't remember
custom group setting when reloading the page after spellcheck. Thus
users who spellcheck and update w/o reentering custom groups suffer.
Tested.

bradfitz: I changed it a bit, to make the hidden checkbox block visible
also after submitting.


To generate a diff of this commit:
cvs rdiff -r1.21 -r1.22 livejournal/htdocs/update.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/update.bml.diff?r1=1.21&r2=1.22

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Sun May 5 20:04:57 UTC 2002

Modified Files:
---------------
livejournal/htdocs: talkpost_do.bml

Log Message:
------------
avva: By popular demand, this adds a link to the whole discussion in emails
sent by talkpost_do.bml (this link used to be there, but was recently
changed to a link to the specific thread; turns out both are really
needed and appreciated). It's added both in text and HTML emails (it's
already there in the HTML at the beginning of the email, so it's
now duplicated at the end for consistency and ease of use). Tested.


To generate a diff of this commit:
cvs rdiff -r1.55 -r1.56 livejournal/htdocs/talkpost_do.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/talkpost_do.bml.diff?r1=1.55&r2=1.56

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Sun May 5 20:21:22 UTC 2002

Modified Files:
---------------
livejournal/bin/upgrading: en.dat texttool.pl
livejournal/htdocs: talkpost.bml talkread.bml

Log Message:
------------
avva: By popular demand, this adds a link to the whole discussion in emails
sent by talkpost_do.bml (this link used to be there, but was recently
changed to a link to the specific thread; turns out both are really
needed and appreciated). It's added both in text and HTML emails (it's
already there in the HTML at the beginning of the email, so it's
now duplicated at the end for consistency and ease of use). Tested.

bradfitz: always make thread/parent links visible if applicable,
by request of bostonsteamer here:
http://www.livejournal.com/talkread.bml?journal=suggestions&itemid=173200

also, make link to read comments from a read comment page if there is
hidden stuff and no navcrap links (only one page)

also, add two new strings to trans db.


To generate a diff of this commit:
cvs rdiff -r1.6 -r1.7 livejournal/bin/upgrading/en.dat
http://cvs.livejournal.org/browse.cgi/livejournal/bin/upgrading/en.dat.diff?r1=1.6&r2=1.7
cvs rdiff -r1.10 -r1.11 livejournal/bin/upgrading/texttool.pl
http://cvs.livejournal.org/browse.cgi/livejournal/bin/upgrading/texttool.pl.diff?r1=1.10&r2=1.11
cvs rdiff -r1.48 -r1.49 livejournal/htdocs/talkpost.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/talkpost.bml.diff?r1=1.48&r2=1.49
cvs rdiff -r1.65 -r1.66 livejournal/htdocs/talkread.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/talkread.bml.diff?r1=1.65&r2=1.66

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Sun May 5 20:35:10 UTC 2002

Modified Files:
---------------
livejournal/htdocs: editpics.bml
livejournal/htdocs/support: see_request.bml

Log Message:
------------
5). BML is parsed in userpic keywords and in support requests. If a user
accidentally uses a BML opening flag in a user picture keyword, his or her
userpics can no longer be edited. If a support volunteer accidentally uses
a BML opening flag in a support answer, that request is effectively "dead
in the water" -- no further updates can be made to that request, as the
input box is no longer there.

Support requests:
http://www.livejournal.com/support/see_request.bml?id=41931

Posts to lj_* communities:
http://www.livejournal.com/talkread.bml?journal=lj_support&itemid=208878
http://www.livejournal.com/talkread.bml?journal=suggestions&itemid=143042

Status: Reproducable. Patch written (by Lucretio), never applied.

Severity: 3
[only affects people who accidentally use BML in their keywords, but there
is a request that has been open for 6 weeks by a user that has]


To generate a diff of this commit:
cvs rdiff -r1.13 -r1.14 livejournal/htdocs/editpics.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/editpics.bml.diff?r1=1.13&r2=1.14
cvs rdiff -r1.21 -r1.22 livejournal/htdocs/support/see_request.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/support/see_request.bml.diff?r1=1.21&r2=1.22

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Sun May 5 20:59:27 UTC 2002

Modified Files:
---------------
livejournal/bin/upgrading: en.dat
livejournal/htdocs: talkread.bml

Log Message:
------------
make talkread translatable, and fix accidentally linked right paren.


To generate a diff of this commit:
cvs rdiff -r1.7 -r1.8 livejournal/bin/upgrading/en.dat
http://cvs.livejournal.org/browse.cgi/livejournal/bin/upgrading/en.dat.diff?r1=1.7&r2=1.8
cvs rdiff -r1.67 -r1.68 livejournal/htdocs/talkread.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/talkread.bml.diff?r1=1.67&r2=1.68

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Sun May 5 21:12:47 UTC 2002

Modified Files:
---------------
livejournal/bin/upgrading: en.dat
livejournal/htdocs: talkread.bml

Log Message:
------------
whoops, in community case was tacking on fixed english. fixed: add new
string for community case.


To generate a diff of this commit:
cvs rdiff -r1.8 -r1.9 livejournal/bin/upgrading/en.dat
http://cvs.livejournal.org/browse.cgi/livejournal/bin/upgrading/en.dat.diff?r1=1.8&r2=1.9
cvs rdiff -r1.68 -r1.69 livejournal/htdocs/talkread.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/talkread.bml.diff?r1=1.68&r2=1.69