April 22nd, 2002

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Mon Apr 22 12:51:05 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin: ljlib.pl
livejournal/htdocs: talkpost_do.bml

Log Message:
------------
avva: Hey,

This patch removes earlier bytes-based checking for overly long
comments and checks both byte length and char length against
$LJ::BMAX_COMMENT, $LJ::CMAX_COMMENT. Note that it abolishes the
existing practice of letting anonymous posters writer only twice as
short comments. I could add another pair of constants just for
anonymous comments, but is there really a point?

It adds a new function, LJ::text_length(), into ljlib. I'll send
another patch later which uses that function in postevent and
returns with an error instead of silently truncating.

Tested.


To generate a diff of this commit:
cvs rdiff -r1.182 -r1.183 livejournal/cgi-bin/ljlib.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/ljlib.pl.diff?r1=1.182&r2=1.183
cvs rdiff -r1.53 -r1.54 livejournal/htdocs/talkpost_do.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/talkpost_do.bml.diff?r1=1.53&r2=1.54

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Mon Apr 22 12:53:08 UTC 2002

Modified Files:
---------------
livejournal/htdocs: talkpost.bml talkread.bml

Log Message:
------------
avva: OK, here's the patch... it actually fixes two things:

1. In talkread/talkpots, use defaultpicid for the poster's picture if
the keyword supplied matches no picid (this is only for the actual
entry, not for comments... comments are already fine w.r.t. this(.
2. Actually use the ->{'_pictures'}->{$pickw} hash which stores
picid's of keywords. Right now if a user leaves 100 comments in a
thread with the same keyword, we load the picid 100 times. This hash
was put into the source to prevent that, but the job was not
completed.

Tested.


To generate a diff of this commit:
cvs rdiff -r1.47 -r1.48 livejournal/htdocs/talkpost.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/talkpost.bml.diff?r1=1.47&r2=1.48
cvs rdiff -r1.64 -r1.65 livejournal/htdocs/talkread.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/talkread.bml.diff?r1=1.64&r2=1.65

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Mon Apr 22 19:00:04 UTC 2002

Modified Files:
---------------
livejournal/htdocs: customview.cgi

Log Message:
------------
let embedders choose charset (avva)

BTW, somebody ... we need to change embedding documentation to
detail this.

Also, one super-safe encoding type (maybe the default type?) should be
to during all 8-bit into HTML numeric entities. Bloat, but safe.


To generate a diff of this commit:
cvs rdiff -r1.8 -r1.9 livejournal/htdocs/customview.cgi
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/customview.cgi.diff?r1=1.8&r2=1.9

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Mon Apr 22 19:37:58 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin: ljlib.pl ljviews.pl
livejournal/htdocs: customview.cgi

Log Message:
------------
finish details of customview charset changing. (have to tell ljlib/ljviews
not to put utf-8 in the body, since we'll be changing it later)


To generate a diff of this commit:
cvs rdiff -r1.183 -r1.184 livejournal/cgi-bin/ljlib.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/ljlib.pl.diff?r1=1.183&r2=1.184
cvs rdiff -r1.44 -r1.45 livejournal/cgi-bin/ljviews.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/ljviews.pl.diff?r1=1.44&r2=1.45
cvs rdiff -r1.9 -r1.10 livejournal/htdocs/customview.cgi
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/customview.cgi.diff?r1=1.9&r2=1.10

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Mon Apr 22 19:42:32 UTC 2002

Modified Files:
---------------
livejournal/bin/upgrading: texttool.pl
livejournal/cgi-bin: ljlang.pl
Added Files:
------------
livejournal/htdocs/translate: edit.bml help-severity.bml index.bml
search.bml searchform.bml welcome.bml

Log Message:
------------
more translation work.

noteable:

- texttool command to trickle down new imported text to child languages

- start of BML editing framework (this should go pretty quick compared
to everything else)

the end is near.


To generate a diff of this commit:
cvs rdiff -r1.4 -r1.5 livejournal/bin/upgrading/texttool.pl
http://cvs.livejournal.org/browse.cgi/livejournal/bin/upgrading/texttool.pl.diff?r1=1.4&r2=1.5
cvs rdiff -r1.6 -r1.7 livejournal/cgi-bin/ljlang.pl
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/ljlang.pl.diff?r1=1.6&r2=1.7
cvs rdiff -r0 -r1.1 livejournal/htdocs/translate/edit.bml \
livejournal/htdocs/translate/help-severity.bml \
livejournal/htdocs/translate/index.bml \
livejournal/htdocs/translate/search.bml \
livejournal/htdocs/translate/searchform.bml \
livejournal/htdocs/translate/welcome.bml
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/translate/edit.bml.diff?r1=0&r2=1.1
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/translate/help-severity.bml.diff?r1=0&r2=1.1
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/translate/index.bml.diff?r1=0&r2=1.1
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/translate/search.bml.diff?r1=0&r2=1.1
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/translate/searchform.bml.diff?r1=0&r2=1.1
http://cvs.livejournal.org/browse.cgi/livejournal/htdocs/translate/welcome.bml.diff?r1=0&r2=1.1

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Mon Apr 22 19:55:00 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin/LJ: TextMessage.pm

Log Message:
------------
add from address to voicestream2 in msg (for amberangel, and me, when I get back to the US)


To generate a diff of this commit:
cvs rdiff -r1.4 -r1.5 livejournal/cgi-bin/LJ/TextMessage.pm
http://cvs.livejournal.org/browse.cgi/livejournal/cgi-bin/LJ/TextMessage.pm.diff?r1=1.4&r2=1.5