January 28th, 2002

livejournal: cmd buffer

Module Name: livejournal
Committed By: bradfitz
Date: Mon Jan 28 08:52:55 UTC 2002

Modified Files:
---------------
livejournal/bin: qbufferd.pl
livejournal/cgi-bin: ljlib.pl ljprotocol.pl
livejournal/htdocs: delcomment.bml talkpost_do.bml

Log Message:
------------
- cluster fixes
- mostly cmdbuffer stuff
- deleting items lazily works now
- new function to delete comments, and delcomment uses it
- etc etc


To generate a diff of this commit:
cvs rdiff -r1.5 -r1.6 livejournal/bin/qbufferd.pl
http://danga.com/lj/cvsweb.cgi/livejournal/bin/qbufferd.pl.diff?r1=1.5&r2=1.6
cvs rdiff -r1.135 -r1.136 livejournal/cgi-bin/ljlib.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljlib.pl.diff?r1=1.135&r2=1.136
cvs rdiff -r1.68 -r1.69 livejournal/cgi-bin/ljprotocol.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljprotocol.pl.diff?r1=1.68&r2=1.69
cvs rdiff -r1.8 -r1.9 livejournal/htdocs/delcomment.bml
http://danga.com/lj/cvsweb.cgi/livejournal/htdocs/delcomment.bml.diff?r1=1.8&r2=1.9
cvs rdiff -r1.31 -r1.32 livejournal/htdocs/talkpost_do.bml
http://danga.com/lj/cvsweb.cgi/livejournal/htdocs/talkpost_do.bml.diff?r1=1.31&r2=1.32

livejournal: ljfunc stuff

Module Name: livejournal
Committed By: bradfitz
Date: Mon Jan 28 20:28:28 UTC 2002

Modified Files:
---------------
livejournal/bin: apidoc.pl
livejournal/cgi-bin: ljlib.pl

Log Message:
------------
- apidoc now can optionally generate LJFUNC stubs
- ran apidoc with --stubs on ljlib. will fill in later.


To generate a diff of this commit:
cvs rdiff -r1.5 -r1.6 livejournal/bin/apidoc.pl
http://danga.com/lj/cvsweb.cgi/livejournal/bin/apidoc.pl.diff?r1=1.5&r2=1.6
cvs rdiff -r1.138 -r1.139 livejournal/cgi-bin/ljlib.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljlib.pl.diff?r1=1.138&r2=1.139

livejournal: ljfunc

Module Name: livejournal
Committed By: bradfitz
Date: Mon Jan 28 20:50:38 UTC 2002

Modified Files:
---------------
livejournal/bin: apidoc.pl
livejournal/cgi-bin: ljlib.pl

Log Message:
------------
more documentation. so much still needed. ;(


To generate a diff of this commit:
cvs rdiff -r1.6 -r1.7 livejournal/bin/apidoc.pl
http://danga.com/lj/cvsweb.cgi/livejournal/bin/apidoc.pl.diff?r1=1.6&r2=1.7
cvs rdiff -r1.139 -r1.140 livejournal/cgi-bin/ljlib.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljlib.pl.diff?r1=1.139&r2=1.140

livejournal: polls working & ampersand policy change

Module Name: livejournal
Committed By: bradfitz
Date: Mon Jan 28 21:37:43 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin: ljlib.pl ljpoll.pl ljprotocol.pl ljviews.pl
livejournal/htdocs: talkpost.bml talkread.bml

Log Message:
------------
The main point of this patch was to make poll cooperate in clustered journals.

In the process I cleaned a lot of crap up and realized something: when
we make URLs to pass off to the style system, or make them in
functions like LJ::item_link, we shouldn't be making & into &
because we *think* it'll be used in HTML. We really can't know how
the style user will use it. It's up to the style to do a
transformation on it if it's used in an attribute. Like:
%%eh:readurl%%

Also, I removed the &nc= (number comments) crap, because I hate it.
Sorry, mart. (or whoever did like it) It's really wrong.


To generate a diff of this commit:
cvs rdiff -r1.140 -r1.141 livejournal/cgi-bin/ljlib.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljlib.pl.diff?r1=1.140&r2=1.141
cvs rdiff -r1.7 -r1.8 livejournal/cgi-bin/ljpoll.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljpoll.pl.diff?r1=1.7&r2=1.8
cvs rdiff -r1.69 -r1.70 livejournal/cgi-bin/ljprotocol.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljprotocol.pl.diff?r1=1.69&r2=1.70
cvs rdiff -r1.31 -r1.32 livejournal/cgi-bin/ljviews.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljviews.pl.diff?r1=1.31&r2=1.32
cvs rdiff -r1.35 -r1.36 livejournal/htdocs/talkpost.bml
http://danga.com/lj/cvsweb.cgi/livejournal/htdocs/talkpost.bml.diff?r1=1.35&r2=1.36
cvs rdiff -r1.42 -r1.43 livejournal/htdocs/talkread.bml
http://danga.com/lj/cvsweb.cgi/livejournal/htdocs/talkread.bml.diff?r1=1.42&r2=1.43

livejournal: strip_bad_code wrapper

Module Name: livejournal
Committed By: bradfitz
Date: Mon Jan 28 21:49:49 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin: cleanhtml.pl ljlib.pl

Log Message:
------------
patch from supersat to make strip_bad_code just be a wrapper
around cleanhtml.pl.

i also added some require lines and LJDEP info.

and there's some cleanhtml.pl stuff i forgot to check in a few minutes
ago too (HTML-escaping the cuturl)


To generate a diff of this commit:
cvs rdiff -r1.10 -r1.11 livejournal/cgi-bin/cleanhtml.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/cleanhtml.pl.diff?r1=1.10&r2=1.11
cvs rdiff -r1.141 -r1.142 livejournal/cgi-bin/ljlib.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljlib.pl.diff?r1=1.141&r2=1.142

livejournal: functionize duplicate code

Module Name: livejournal
Committed By: bradfitz
Date: Mon Jan 28 22:00:29 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin: ljlib.pl ljviews.pl

Log Message:
------------
been meaning to make a function out of this for awhile.


To generate a diff of this commit:
cvs rdiff -r1.142 -r1.143 livejournal/cgi-bin/ljlib.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljlib.pl.diff?r1=1.142&r2=1.143
cvs rdiff -r1.32 -r1.33 livejournal/cgi-bin/ljviews.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljviews.pl.diff?r1=1.32&r2=1.33

livejournal: BML - be verbose about VarInitScript errors

Module Name: livejournal
Committed By: bradfitz
Date: Mon Jan 28 22:59:53 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin: bmlp.pl

Log Message:
------------
Some poor Windows users that didn't know Perl were going crazy trying
to debug why their LJ installations were failing. This should point
them in the right direction, making BML be loud about things that fail
when lj-bml-init.pl starts up and can't find libraries.


To generate a diff of this commit:
cvs rdiff -r1.11 -r1.12 livejournal/cgi-bin/bmlp.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/bmlp.pl.diff?r1=1.11&r2=1.12

livejournal: dudata, deletions

Module Name: livejournal
Committed By: bradfitz
Date: Mon Jan 28 23:13:43 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin: ljlib.pl ljprotocol.pl
livejournal/htdocs: talkpost_do.bml

Log Message:
------------
- lot of places dudata wasn't being set, or set correctly
- added new LJ::dudata_set function (with docs!)
- fixed bug where entries' comments weren't being deleted.


To generate a diff of this commit:
cvs rdiff -r1.143 -r1.144 livejournal/cgi-bin/ljlib.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljlib.pl.diff?r1=1.143&r2=1.144
cvs rdiff -r1.70 -r1.71 livejournal/cgi-bin/ljprotocol.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljprotocol.pl.diff?r1=1.70&r2=1.71
cvs rdiff -r1.32 -r1.33 livejournal/htdocs/talkpost_do.bml
http://danga.com/lj/cvsweb.cgi/livejournal/htdocs/talkpost_do.bml.diff?r1=1.32&r2=1.33

livejournal: unnecessary code

Module Name: livejournal
Committed By: bradfitz
Date: Mon Jan 28 23:24:50 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin: cleanhtml.pl

Log Message:
------------

This was a security thing we did back-when after discovering we had a
few URLs which did an action based on $remote. The problem is that a
GET request shouldn't do an action, since it can be hidden in an IMG
tag in somebody's post:

[img src="http://lj.com/delete_all_your_shit.bml?confirm=yes" width=1
height=1]

But I think we've long-since fixed all those cases, so this code is
no longer necessary.


To generate a diff of this commit:
cvs rdiff -r1.11 -r1.12 livejournal/cgi-bin/cleanhtml.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/cleanhtml.pl.diff?r1=1.11&r2=1.12

livejournal: no backdated posts in communities

Module Name: livejournal
Committed By: bradfitz
Date: Mon Jan 28 23:43:20 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin: ljprotocol.pl

Log Message:
------------
Disallow back-dated posts in communities.
They don't make sense, and they don't work anyway.
Why?
We mess around with rlogtime to make backdated work.
And we use rlogtime for sorting on non-personal journals.
And I'll need to rely on that for skipping about in go.bml next.
Basically, this is how it always should've been.


To generate a diff of this commit:
cvs rdiff -r1.71 -r1.72 livejournal/cgi-bin/ljprotocol.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljprotocol.pl.diff?r1=1.71&r2=1.72

livejournal: prev/next go links

Module Name: livejournal
Committed By: bradfitz
Date: Tue Jan 29 00:55:19 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin: ljlib.pl
livejournal/htdocs: go.bml

Log Message:
------------
go.bml is fast now, for both clustered & non-clustered cases.
also, given how it's done now, it'd be trivial to make the links support
$remote user's security now. but that's for later.


To generate a diff of this commit:
cvs rdiff -r1.144 -r1.145 livejournal/cgi-bin/ljlib.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljlib.pl.diff?r1=1.144&r2=1.145
cvs rdiff -r1.3 -r1.4 livejournal/htdocs/go.bml
http://danga.com/lj/cvsweb.cgi/livejournal/htdocs/go.bml.diff?r1=1.3&r2=1.4

livejournal: support bug

Module Name: livejournal
Committed By: bradfitz
Date: Tue Jan 29 02:29:06 UTC 2002

Modified Files:
---------------
livejournal/htdocs/support: submit_do.bml

Log Message:
------------
Somehow these two lines got flipped.
It complained about errors before it checked for errors.
Props to sherm


To generate a diff of this commit:
cvs rdiff -r1.8 -r1.9 livejournal/htdocs/support/submit_do.bml
http://danga.com/lj/cvsweb.cgi/livejournal/htdocs/support/submit_do.bml.diff?r1=1.8&r2=1.9

livejournal

Module Name: livejournal
Committed By: bradfitz
Date: Tue Jan 29 04:45:13 UTC 2002

Modified Files:
---------------
livejournal/cgi-bin: ljlib.pl
livejournal/htdocs: delcomment.bml

Log Message:
------------
on clusters, was doing hard deletes on comments, not delete flagging.


To generate a diff of this commit:
cvs rdiff -r1.145 -r1.146 livejournal/cgi-bin/ljlib.pl
http://danga.com/lj/cvsweb.cgi/livejournal/cgi-bin/ljlib.pl.diff?r1=1.145&r2=1.146
cvs rdiff -r1.9 -r1.10 livejournal/htdocs/delcomment.bml
http://danga.com/lj/cvsweb.cgi/livejournal/htdocs/delcomment.bml.diff?r1=1.9&r2=1.10