sunnyman's (sunnyman) wrote in changelog,
sunnyman's
sunnyman
changelog

[ljcom] r12532: LJSUP-13250: Pre refactoring for all pro...

Committer: vtroitsky
LJSUP-13250: Pre refactoring for all promo projects that already have been done
U   trunk/cgi-bin/LJ/Pay/Payment/PayItem/SelfPromo.pm
Modified: trunk/cgi-bin/LJ/Pay/Payment/PayItem/SelfPromo.pm
===================================================================
--- trunk/cgi-bin/LJ/Pay/Payment/PayItem/SelfPromo.pm	2012-08-23 11:57:29 UTC (rev 12531)
+++ trunk/cgi-bin/LJ/Pay/Payment/PayItem/SelfPromo.pm	2012-08-23 12:37:47 UTC (rev 12532)
@@ -31,9 +31,10 @@
     my ($self, $subitem) = @_;
     $subitem = $self->get_subitem();
     my $sp_type = $self->get_prop('selfpromo');
-    my $prefix = 'selfpromo';
+    my $prefix = 'selfpromo';   # TODO: Make it dependent on
 
     # TODO: Refactor and move this later into LJ::Pay::Promotion->new_from_cart_item($self)
+    # split subitem into promo class - 
     if ( $subitem && $subitem =~ /^commercial\-(\d+)$/ ) {
         # Create promotion object here       
         my $promo = LJ::Pay::Promotion::Commercial->new($1);
@@ -58,7 +59,7 @@
     my $qty = $self->get_qty;
 
     my $subitem = $self->get_subitem();
-    my $prefix = ( $subitem && $subitem =~ /^commercial/ ? 'commercial' : 'selfpromo'); # Make it better
+    my $prefix = ( $subitem && $subitem =~ /^commercial/ ? 'commercial' : 'selfpromo'); # TODO: Make it better
 
     return {
         'name' => $self->get_product_name,

Tags: ljcom, pm, sunnyman, vtroitsky
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 0 comments