quwiero wrote in changelog

[ljcom] r11932: LJSUP-11906: Userhead admin tool improve...

Committer: sboronchiev
LJSUP-11906: Userhead admin tool improvements
U   trunk/htdocs/admin/userheads/manage.bml

Modified: trunk/htdocs/admin/userheads/manage.bml
===================================================================
--- trunk/htdocs/admin/userheads/manage.bml	2012-05-12 10:53:47 UTC (rev 11931)
+++ trunk/htdocs/admin/userheads/manage.bml	2012-05-12 11:37:59 UTC (rev 11932)
@@ -24,19 +24,19 @@
     
     my $uh = LJ::UserHead->get_userhead ($FORM{'edit'});
     $ret .= "<title>LJ User Heads: Edit</title>";
-    $ret .= "Edit userhead: #".$FORM{'edit'}."<br/>";
-    $ret .= "<img src='".$uh->get_uh_img."'>";
+    $ret .= "<h2>Edit userhead: #".$FORM{'edit'}."</h2>";
+    $ret .= "<p><img src='".$uh->get_uh_img."' alt='' /></p>";
     $ret .= <<FORM;
     <form method="post" enctype="multipart/form-data">
     <table>
     <tr>
-        <td><input type="file" name="uh_file"></td>
-        <td><input type="submit" name="upload" value="Replace"></td>
+        <td><input type="file" name="uh_file" /></td>
+        <td><input type="submit" name="upload" value="Replace" /></td>
     </tr>
     </table>
-    <input type='hidden' name='uh_id' value='$FORM{edit}'>
+    <p><input type='hidden' name='uh_id' value='$FORM{edit}' /></p>
     </form>
-    <hr>
+    <hr />
 
 FORM
     return $ret;
@@ -123,22 +123,23 @@
 
 my $dbh = LJ::get_db_writer();
 
-    $ret .= "<font color=\"red\"><b>".$save_error."</b></font>" if $save_error;
+    $ret .= "<b>".$save_error."</b>" if $save_error;
 
     $ret .= <<FORM;
     <form method="post" enctype="multipart/form-data">
     <table>
     <tr>
-        <td><input type="file" name="uh_file"></td>
-        <td><input type="submit" name="upload" value="Upload"></td>
+        <td><input type="file" name="uh_file" /></td>
+        <td><input type="submit" name="upload" value="Upload" /></td>
     </tr>
     <tr>
         <td align="left" colspan="2"><a href="/admin/userheads/stat.bml">Show statistics</a></td>
     </tr>
     </table>
     </form>
-    <hr>
 
+    <hr />
+
 FORM
 
 my $uhs = LJ::UserHead->get_all_userheads();
@@ -167,29 +168,29 @@
 );
 
 $ret .= "<form method='POST'>";
-$ret .= "<table border=0 cellspacing=1 cellpadding=4>";
-$ret .= "<tr><td>Id</td><td>Img Enb</td><td>Img Dis</td><td>Cost</td><td>&nbsp;</td><td>Author</td><td>Description</td><td>Description SUP</td><td>Individual user buyer</td><td>Indv. expdate (<span style=\"font-size:10px;\">YYYYMMDD</span>)</td><td>Edit</td></tr>";
+$ret .= "<table border='0' cellspacing='1' cellpadding='4'>";
+$ret .= "<tr><th>Id</th><th>Img Enb</th><th>Img Dis</th><th>Cost</th><th>&nbsp;</th><th>Author</th><th>Description</th><th>Description SUP</th><th>Individual user buyer</th><th>Indv. expdate (<small>YYYYMMDD</small>)</th><th>Edit</th></tr>";
 foreach my $uh (@$uhs) {
     $ret .= "<tr>\n";
-    $ret .= "<td><input type='hidden' name='".$uh->get_uh_id."-uh_id' value='".$uh->get_uh_id."'>".$uh->get_uh_id."</td>\n";
+    $ret .= "<td><input type='hidden' name='".$uh->get_uh_id."-uh_id' value='".$uh->get_uh_id."' />".$uh->get_uh_id."</td>\n";
     $ret .= "<td>";
     if ($uh->get_visibility ne 'D') {
-        $ret .= "<img src='".$uh->get_uh_img."'>";
+        $ret .= "<img src='".$uh->get_uh_img."' alt='' />";
     } else {
-        $ret .= "&nbsp;";
+        $ret .= " ";
     }
     $ret .= "</td>\n";
     $ret .= "<td>";
     if ($uh->get_visibility eq 'D') {
-        $ret .= "<img src='".$uh->get_uh_img."'>";
+        $ret .= "<img src='".$uh->get_uh_img."' />";
     } else {
-        $ret .= "&nbsp;";
+        $ret .= " ";
     }
     $ret .= "</td>\n";
-    $ret .= "<td><input type='text' name='".$uh->get_uh_id."-price' size='5' value='".$uh->get_price."'></td>\n";
+    $ret .= "<td><input type='text' name='".$uh->get_uh_id."-price' size='5' value='".$uh->get_price."' /></td>\n";
     $ret .= "<td><select name='".$uh->get_uh_id."-visibility'>\n";
     foreach my $sel (@selects) {
-        $ret .= "\t<option value='".$sel->{'value'}."'".($uh->get_visibility eq $sel->{'value'} ? "qazxsqq selected='selected' " : "").">".$sel->{'name'}."</option>\n";
+        $ret .= "\t<option value='".$sel->{'value'}."'".($uh->get_visibility eq $sel->{'value'} ? " selected='selected' " : "").">".$sel->{'name'}."</option>\n";
     }
     $ret .= "</select></td>\n";
     my $exp_date = "";
@@ -204,27 +205,27 @@
             }
         }
     }
-    $ret .= "<td><input type='text' name='".$uh->get_uh_id."-author' value='".$uh->get_uh_author."'></td>\n";
-    $ret .= "<td><input type='text' name='".$uh->get_uh_id."-desc' value='".$uh->get_uh_desc."'></td>\n";
-    $ret .= "<td><input type='text' name='".$uh->get_uh_id."-desc-sup' value='".$uh->get_uh_desc_sup."'></td>\n";
-    $ret .= "<td><input type='text' name='".$uh->get_uh_id."-buyer' value='".$uh->get_individ_buyer."'></td>\n";
-    $ret .= "<td><input type='text' name='".$uh->get_uh_id."-expdate' value='".$exp_date."'></td>\n";
-    $ret .= "<td><input type='submit' name='edit' value='".$uh->get_uh_id."'></td>\n";
+    $ret .= "<td><input type='text' name='".$uh->get_uh_id."-author' value='".$uh->get_uh_author."' /></td>\n";
+    $ret .= "<td><input type='text' name='".$uh->get_uh_id."-desc' value='".$uh->get_uh_desc."' /></td>\n";
+    $ret .= "<td><input type='text' name='".$uh->get_uh_id."-desc-sup' value='".$uh->get_uh_desc_sup."' /></td>\n";
+    $ret .= "<td><input type='text' name='".$uh->get_uh_id."-buyer' value='".$uh->get_individ_buyer."' /></td>\n";
+    $ret .= "<td><input type='text' name='".$uh->get_uh_id."-expdate' value='".$exp_date."' /></td>\n";
+    $ret .= "<td><input type='submit' name='edit' value='".$uh->get_uh_id."' /></td>\n";
     $ret .= "</tr>\n";
 }
-$ret .= "<tr><td colspan='5'><input type='submit' name='save' value='Save'></td></tr>\n";
+$ret .= "<tr><td colspan='5'><input type='submit' name='save' value='Save' /></td></tr>\n";
 $ret .= "</table></form>";
 
-$ret .= "<hr>";
+$ret .= "<hr />";
 
 $ret .= "<form method='POST'>";
-$ret .= "<b>Set user head:&nbsp;</b><select name='uh_id'>";
+$ret .= "<p><label for='uh_id'>Set user head:&nbsp;</label><select id='uh_id' name='uh_id'>";
 foreach my $uh (@$uhs) {
-    $ret .= "<option value=".$uh->get_uh_id.">".$uh->get_uh_id."</option>";
+    $ret .= "<option value='".$uh->get_uh_id."'>".$uh->get_uh_id."</option>";
 }
-$ret .= "</select>&nbsp;to LJ users:<br/>";
-$ret .= "<textarea name='users' rows='5' cols='30'>Usernames, comma separated</textarea><br/>";
-$ret .= "<input type='submit' name='set' value='Set'>";
+$ret .= "</select>&nbsp;to LJ users:</p>";
+$ret .= "<textarea name='users' rows='5' cols='30'>Usernames, comma separated</textarea>";
+$ret .= "<p><input type='submit' name='set' value='Set' /></p>";
 $ret .= "</form>";
 
 return $ret;
bmlljcomquwierosboronchiev

LJ Video