Igor Gariev (gariev) wrote in changelog,
Igor Gariev
gariev
changelog

[livejournal] r20311: Assorted fixes and clean-ups here and th...

Committer: gariev
Assorted fixes and clean-ups here and there
U   trunk/cgi-bin/LJ/Setting.pm
U   trunk/cgi-bin/LJ/Widget/IPPU/AddAlias.pm
U   trunk/cgi-bin/ljhooks.pl
Modified: trunk/cgi-bin/LJ/Setting.pm
===================================================================
--- trunk/cgi-bin/LJ/Setting.pm	2011-10-14 00:22:16 UTC (rev 20310)
+++ trunk/cgi-bin/LJ/Setting.pm	2011-10-14 00:39:59 UTC (rev 20311)
@@ -121,7 +121,7 @@
     my $errclass = $class;
     $errclass =~ s/^LJ::Setting:://;
     $errclass = "LJ::Error::SettingSave::" . $errclass;
-    eval "\@${errclass}::ISA = ('LJ::Error::SettingSave');";
+    @{"${errclass}::ISA"} = ('LJ::Error::SettingSave');
 
     my $eo = eval { $errclass->new(map => \%map) };
     $eo->log;

Modified: trunk/cgi-bin/LJ/Widget/IPPU/AddAlias.pm
===================================================================
--- trunk/cgi-bin/LJ/Widget/IPPU/AddAlias.pm	2011-10-14 00:22:16 UTC (rev 20310)
+++ trunk/cgi-bin/LJ/Widget/IPPU/AddAlias.pm	2011-10-14 00:39:59 UTC (rev 20311)
@@ -3,10 +3,6 @@
 use strict;
 use base qw(LJ::Widget::IPPU);
 use Carp qw(croak);
-use Class::Autouse qw(
-                      LJ::JSUtil
-                      );
-
 use LJ::JSON;
 
 sub need_res {

Modified: trunk/cgi-bin/ljhooks.pl
===================================================================
--- trunk/cgi-bin/ljhooks.pl	2011-10-14 00:22:16 UTC (rev 20310)
+++ trunk/cgi-bin/ljhooks.pl	2011-10-14 00:39:59 UTC (rev 20311)
@@ -102,7 +102,8 @@
     return if $hooks_dir_scanned++;
     # eh, not actually subclasses... just files:
     foreach my $class (LJ::ModuleLoader->module_subclasses("LJ::Hooks")) {
-        eval "use $class;";
+        $class =~ s!::!/!g;
+        require "$class.pm";
         die "Error loading $class: $@" if $@;
     }
 }

Tags: gariev, livejournal, pl, pm
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 0 comments