Андрей (andy) wrote in changelog,
Андрей
andy
changelog

[ljcom] r10553: LJSUP-8865 (ensure that modules in cgi-b...

Committer: ailyin
LJSUP-8865 (ensure that modules in cgi-bin use strict)
U   trunk/cgi-bin/LJ/CProd/AdPlacementPlus.pm
U   trunk/cgi-bin/LJ/CProd/AdsBetweenPostsFree.pm
U   trunk/cgi-bin/LJ/CProd/ControlStrip_AdPlacementFree.pm
U   trunk/cgi-bin/LJ/CProd/ControlStrip_ExpressiveThemesPaid.pm
U   trunk/cgi-bin/LJ/CProd/ControlStrip_LJRU.pm
U   trunk/cgi-bin/LJ/CProd/ControlStrip_Polls.pm
U   trunk/cgi-bin/LJ/CProd/ControlStrip_Sponsored.pm
U   trunk/cgi-bin/LJ/CProd/Directory.pm
U   trunk/cgi-bin/LJ/CProd/DystopiaNav.pm
U   trunk/cgi-bin/LJ/CProd/ESN.pm
U   trunk/cgi-bin/LJ/CProd/EditPics.pm
U   trunk/cgi-bin/LJ/CProd/ExpressiveThemesPaid.pm
U   trunk/cgi-bin/LJ/CProd/FriendsFriendsInline.pm
U   trunk/cgi-bin/LJ/CProd/PaidUpsells/ExpressLane.pm
U   trunk/cgi-bin/LJ/CProd/PaidUpsells/ExtraStyles.pm
U   trunk/cgi-bin/LJ/CProd/PaidUpsells/ExtraUserpics.pm
U   trunk/cgi-bin/LJ/CProd/PaidUpsells/LoyaltyUserpics.pm
U   trunk/cgi-bin/LJ/CProd/PaidUpsells/MassSecurity.pm
U   trunk/cgi-bin/LJ/CProd/PaidUpsells/StorageSpace.pm
U   trunk/cgi-bin/LJ/CProd/PaidUpsells/ThreadTracking.pm
U   trunk/cgi-bin/LJ/CProd/PaidUpsells/VoicePost.pm
U   trunk/cgi-bin/LJ/CProd/SMS/NonBranded1.pm
U   trunk/cgi-bin/LJ/CProd/SMS/NonBranded2.pm
U   trunk/cgi-bin/LJ/CProd/Syn.pm
U   trunk/cgi-bin/LJ/CProd/TodoMaxItems.pm
Modified: trunk/cgi-bin/LJ/CProd/AdPlacementPlus.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/AdPlacementPlus.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/AdPlacementPlus.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::AdPlacementPlus;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/AdsBetweenPostsFree.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/AdsBetweenPostsFree.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/AdsBetweenPostsFree.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::AdsBetweenPostsFree;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/ControlStrip_AdPlacementFree.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/ControlStrip_AdPlacementFree.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/ControlStrip_AdPlacementFree.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,5 +1,8 @@
+package LJ::CProd::ControlStrip_AdPlacementFree;
+use strict;
+
 # Control strip CProd for polls
-package LJ::CProd::ControlStrip_AdPlacementFree;
+
 use base 'LJ::CProd';
 
 # Inline only!

Modified: trunk/cgi-bin/LJ/CProd/ControlStrip_ExpressiveThemesPaid.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/ControlStrip_ExpressiveThemesPaid.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/ControlStrip_ExpressiveThemesPaid.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,5 +1,8 @@
+package LJ::CProd::ControlStrip_ExpressiveThemesPaid;
+use strict;
+
 # Control strip CProd for polls
-package LJ::CProd::ControlStrip_ExpressiveThemesPaid;
+
 use base 'LJ::CProd';
 
 # Inline only!

Modified: trunk/cgi-bin/LJ/CProd/ControlStrip_LJRU.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/ControlStrip_LJRU.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/ControlStrip_LJRU.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::ControlStrip_LJRU;
+use strict;
+
 use base 'LJ::CProd';
 
 # Inline only!

Modified: trunk/cgi-bin/LJ/CProd/ControlStrip_Polls.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/ControlStrip_Polls.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/ControlStrip_Polls.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,9 +1,11 @@
-# Control strip CProd for polls
 package LJ::CProd::ControlStrip_Polls;
-use base 'LJ::CProd';
+use strict;
 
+# Control strip CProd for polls
 # Inline only!
 
+use base 'LJ::CProd';
+
 sub applicable {
     my ($class, $u) = @_;
 

Modified: trunk/cgi-bin/LJ/CProd/ControlStrip_Sponsored.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/ControlStrip_Sponsored.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/ControlStrip_Sponsored.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::ControlStrip_Sponsored;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/Directory.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/Directory.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/Directory.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::Directory;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/DystopiaNav.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/DystopiaNav.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/DystopiaNav.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::DystopiaNav;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/ESN.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/ESN.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/ESN.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,7 +1,8 @@
 package LJ::CProd::ESN;
-use base 'LJ::CProd';
 use strict;
 
+use base 'LJ::CProd';
+
 sub applicable {
     my ($class, $u) = @_;
     return unless $u;

Modified: trunk/cgi-bin/LJ/CProd/EditPics.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/EditPics.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/EditPics.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,7 +1,8 @@
 package LJ::CProd::EditPics;
-use base 'LJ::CProd';
 use strict;
 
+use base 'LJ::CProd';
+
 sub applicable {
     my ($class, $u) = @_;
     return 0 if ($u->in_class('extrauserpics') || $u->in_class('perm') || !$u->is_person);

Modified: trunk/cgi-bin/LJ/CProd/ExpressiveThemesPaid.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/ExpressiveThemesPaid.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/ExpressiveThemesPaid.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::ExpressiveThemesPaid;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/FriendsFriendsInline.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/FriendsFriendsInline.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/FriendsFriendsInline.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::FriendsFriendsInline;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {
@@ -13,7 +15,7 @@
 
     my $link = $class->clickthru_link('cprod.friendsfriendsinline.link3', $version);
 
-    return "<p>$icon ".BML::ml($class->get_ml($version), { "user" => $user,
+    return "<p>".BML::ml($class->get_ml($version), { "user" => $user,
                                                  "link" => $link }) . "</p>";
 
 }

Modified: trunk/cgi-bin/LJ/CProd/PaidUpsells/ExpressLane.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/PaidUpsells/ExpressLane.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/PaidUpsells/ExpressLane.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::PaidUpsells::ExpressLane;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/PaidUpsells/ExtraStyles.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/PaidUpsells/ExtraStyles.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/PaidUpsells/ExtraStyles.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::PaidUpsells::ExtraStyles;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/PaidUpsells/ExtraUserpics.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/PaidUpsells/ExtraUserpics.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/PaidUpsells/ExtraUserpics.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::PaidUpsells::ExtraUserpics;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/PaidUpsells/LoyaltyUserpics.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/PaidUpsells/LoyaltyUserpics.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/PaidUpsells/LoyaltyUserpics.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::PaidUpsells::LoyaltyUserpics;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/PaidUpsells/MassSecurity.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/PaidUpsells/MassSecurity.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/PaidUpsells/MassSecurity.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::PaidUpsells::MassSecurity;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/PaidUpsells/StorageSpace.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/PaidUpsells/StorageSpace.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/PaidUpsells/StorageSpace.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::PaidUpsells::StorageSpace;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/PaidUpsells/ThreadTracking.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/PaidUpsells/ThreadTracking.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/PaidUpsells/ThreadTracking.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::PaidUpsells::ThreadTracking;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/PaidUpsells/VoicePost.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/PaidUpsells/VoicePost.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/PaidUpsells/VoicePost.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::PaidUpsells::VoicePost;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Modified: trunk/cgi-bin/LJ/CProd/SMS/NonBranded1.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/SMS/NonBranded1.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/SMS/NonBranded1.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,7 +1,8 @@
 package LJ::CProd::SMS::NonBranded1;
-use base 'LJ::CProd';
 use strict;
 
+use base 'LJ::CProd';
+
 sub applicable {
     my ($class, $u) = @_;
     return 0 if $u->prop('sms_carrier');

Modified: trunk/cgi-bin/LJ/CProd/SMS/NonBranded2.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/SMS/NonBranded2.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/SMS/NonBranded2.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,7 +1,8 @@
 package LJ::CProd::SMS::NonBranded2;
-use base 'LJ::CProd';
 use strict;
 
+use base 'LJ::CProd';
+
 sub applicable {
     my ($class, $u) = @_;
     return 0 if $u->prop('sms_carrier');

Modified: trunk/cgi-bin/LJ/CProd/Syn.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/Syn.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/Syn.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::Syn;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {
@@ -13,7 +15,7 @@
 
     my $link = $class->clickthru_link('cprod.syn.link', $version);
 
-    return "<p>" . BML::ml($class->get_ml($version), { "user" => $user, "link" => $link, "link2" => $link2 }) . "</p>";
+    return "<p>" . BML::ml($class->get_ml($version), { "user" => $user, "link" => $link }) . "</p>";
 
 }
 

Modified: trunk/cgi-bin/LJ/CProd/TodoMaxItems.pm
===================================================================
--- trunk/cgi-bin/LJ/CProd/TodoMaxItems.pm	2011-05-24 04:02:45 UTC (rev 10552)
+++ trunk/cgi-bin/LJ/CProd/TodoMaxItems.pm	2011-05-24 04:07:09 UTC (rev 10553)
@@ -1,4 +1,6 @@
 package LJ::CProd::TodoMaxItems;
+use strict;
+
 use base 'LJ::CProd';
 
 sub applicable {

Tags: andy, ljcom, pm
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 0 comments