vadvs (vadvs) wrote in changelog,
vadvs
vadvs
changelog

[livejournal] r19084: LJSV-1591: Remove XML RPC message from r...

Committer: vsukhanov
LJSV-1591: Remove XML RPC message from remotelog
U   trunk/cgi-bin/Apache/LiveJournal.pm
Modified: trunk/cgi-bin/Apache/LiveJournal.pm
===================================================================
--- trunk/cgi-bin/Apache/LiveJournal.pm	2011-05-19 06:40:51 UTC (rev 19083)
+++ trunk/cgi-bin/Apache/LiveJournal.pm	2011-05-19 06:45:59 UTC (rev 19084)
@@ -2168,8 +2168,16 @@
     ## Without eval/warn/die there will be no error message in our logs,
     ## since XMLRPC::Transport::HTTP::Apache will send the error to client.
     my $res = eval { LJ::Protocol::xmlrpc_method($method, @_) };
-    if ($@) { warn "LJ::XMLRPC::$method died: $@"; die $@; }
+    if ($@) { 
+        ## Do not log XMLRPC exceptions with exception number:
+        ##      305: Client error: Action forbidden; account is suspended. at
+        ## They are useless for Ops, but, yes, they can be useful for engineering debug.
+        ##
+        warn "LJ::XMLRPC::$method died: $@" unless $@ =~ /^\d+?\s*:/; 
 
+        die $@; 
+    }
+
     return $res;
 }
 

Tags: livejournal, pm, vadvs
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 0 comments