Андрей (andy) wrote in changelog,
Андрей
andy
changelog

[livejournal] r18929: LJSV-1525 (http://www.livejournal.com/ad...

Committer: ailyin
LJSV-1525 (http://www.livejournal.com/admin/faq/faqedit.bml not working): eliminate use vars ret
U   trunk/htdocs/admin/contentflag.bml
U   trunk/htdocs/pubkey.bml
U   trunk/htdocs/tools/recent_emailposts.bml
Modified: trunk/htdocs/admin/contentflag.bml
===================================================================
--- trunk/htdocs/admin/contentflag.bml	2011-04-21 04:07:10 UTC (rev 18928)
+++ trunk/htdocs/admin/contentflag.bml	2011-04-21 04:09:39 UTC (rev 18929)
@@ -4,7 +4,7 @@
 <?_code
 {
     use strict;
-    use vars qw(%GET %POST $ret $headextra @errors @warnings);
+    use vars qw(%GET %POST $headextra @errors @warnings);
 
     my $remote = LJ::get_remote();
     return BML::redirect("$LJ::SITEROOT/support/")
@@ -20,9 +20,7 @@
     $opts{catid}  = $POST{catid}  || $GET{catid};
     $opts{sort}   = $POST{sort}   || $GET{sort}   || "count";
 
-    $ret .= $widget->render(%opts);
-
-    return $ret;
+    return $widget->render(%opts);
 }
 _code?>
 <=body

Modified: trunk/htdocs/pubkey.bml
===================================================================
--- trunk/htdocs/pubkey.bml	2011-04-21 04:07:10 UTC (rev 18928)
+++ trunk/htdocs/pubkey.bml	2011-04-21 04:09:39 UTC (rev 18929)
@@ -18,8 +18,10 @@
 <?_code
 {
     use strict;
-    use vars qw(%GET $user $u $ret);
+    use vars qw(%GET);
 
+    my ( $user, $u, $ret );
+
     return $ML{'.error.notconfigured'} unless $LJ::USE_PGP;
     return LJ::server_down_html() if $LJ::SERVER_DOWN;
 

Modified: trunk/htdocs/tools/recent_emailposts.bml
===================================================================
--- trunk/htdocs/tools/recent_emailposts.bml	2011-04-21 04:07:10 UTC (rev 18928)
+++ trunk/htdocs/tools/recent_emailposts.bml	2011-04-21 04:09:39 UTC (rev 18929)
@@ -39,8 +39,10 @@
 <?_code
 {
     use strict;
-    use vars qw/ $ret %POST /;
+    use vars qw/ %POST /;
 
+    my $ret;
+
     return "Sorry, this site is not configured to use the emailgateway."
         unless $LJ::EMAIL_POST_DOMAIN;
     return LJ::server_down_html() if $LJ::SERVER_DOWN;

Tags: andy, bml, livejournal
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 0 comments